He entered Parliament at the 1979 election, after becoming chairman of the Welsh Labour Party in 1977. He was an opposition whip from 1983 to 1995, and retired to the backbenches. He was made a knight in 1996. He continued as constituency MP until his death.
He was opposed to Sunday Trading and was active in Parliament to block legislation to allow it. He was also an opponent of the National Assembly for Wales. His daughter, Janice Gregory, is a member of that assembly.